Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Conformal prediction issues #1179

Merged
merged 6 commits into from
Oct 15, 2024
Merged

[FIX] Conformal prediction issues #1179

merged 6 commits into from
Oct 15, 2024

Conversation

elephaint
Copy link
Contributor

  • Addresses @jose-moralez comments
  • Adds conformal prediction to docs in mint.json

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jmoralez
Copy link
Member

Can you rerun the tutorial? The intervals should be different now

@elephaint
Copy link
Contributor Author

elephaint commented Oct 15, 2024 •
edited
Loading

Can you rerun the tutorial? The intervals should be different now

Thanks, you're right, in my haste I had reran it but didn't see any changes but it is slightly different (the difference isn't noticeable if you're not paying attention closely - good reminder of not to visually judge a forecast, haha)

@jmoralez
Copy link
Member

Thanks. I can't comment on that line but this has to be changed on the other method as well (line 542)

@elephaint
Copy link
Contributor Author

Thanks. I can't comment on that line but this has to be changed on the other method as well (line 542)

For f*cks sake I'm an idiot, jeez

@elephaint elephaint merged commit 23c71bc into main Oct 15, 2024
18 checks passed
@elephaint elephaint deleted the fix/conformal_issues branch October 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoralez jmoralez jmoralez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elephaint @jmoralez